-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Labels
0 - newNew issues that need assignment.New issues that need assignment.estimate - 5A few days of work, definitely requires updates to tests.A few days of work, definitely requires updates to tests.needs milestonePlanning workflow - pending milestone assignment, has priority and/or estimate.Planning workflow - pending milestone assignment, has priority and/or estimate.p - lowIssue is non core or affecting less that 10% of people using the libraryIssue is non core or affecting less that 10% of people using the libraryspikeIssues that need quick investigations for time estimations, prioritization, or a quick assessment.Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Description
Background
Not all properties are reflected to the DOM, however we have a lot of CSS that relies on attribute selectors on the host.
If a property isn't reflected but a attribute selector is used in styles, we may not catch the rendering issue since all of our tests and stories rely on attributes
We need to figure out a way to test components by assigning via attributes and properties
Example:
Input.scss has the following CSS:
:host([prefix-text]) input {
border-start-start-radius: 0;
border-end-start-radius: 0;
}
However, the property prefixText
is not reflected.
The HTML examples use attributes and the screenshot tests use attributes so this error would not be caught if assignign prefixText via a property.
Desired Outcome
Ensuring that assigning values via properties renders the component correctly.
Related to #10959.
Metadata
Metadata
Assignees
Labels
0 - newNew issues that need assignment.New issues that need assignment.estimate - 5A few days of work, definitely requires updates to tests.A few days of work, definitely requires updates to tests.needs milestonePlanning workflow - pending milestone assignment, has priority and/or estimate.Planning workflow - pending milestone assignment, has priority and/or estimate.p - lowIssue is non core or affecting less that 10% of people using the libraryIssue is non core or affecting less that 10% of people using the libraryspikeIssues that need quick investigations for time estimations, prioritization, or a quick assessment.Issues that need quick investigations for time estimations, prioritization, or a quick assessment.