Skip to content

fix: fix core transitions across components #10836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 22, 2024

Related Issue: #10837

Summary

Splits up props set by the transition-default Tailwind util, so they are all configured correctly.

This came up in #10835. It turns out #10835 wasn't set up properly and core transitions were not working.

Note: Removed outline and outline-offset as these were configured with defaults and are not animated by default.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 22, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 22, 2024
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@jcfranco jcfranco merged commit 47fe92d into dev Nov 22, 2024
20 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-default-transition branch November 22, 2024 19:19
benelan added a commit that referenced this pull request Nov 22, 2024
…ernalization

* origin/dev:
  chore: release next
  fix: fix core transitions across components (#10836)
  fix(link): fix underline animation (#10835)
anveshmekala added a commit that referenced this pull request Jan 23, 2025
**Related Issue:** #11371 

## Summary

Removes outline for header actions which is causing transition on focus
shift.

This is introduced with
#10836 where outline
exclusion from transition is ignored in Tailwind util.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #10837

## Summary

Splits up props set by the `transition-default` Tailwind util, so they
are all configured correctly.

This came up in
#10835. It turns out
#10835 wasn't set up
properly and core transitions were not working.

**Note**: Removed `outline` and `outline-offset` as these were
configured with defaults and are not animated by default.
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #11371 

## Summary

Removes outline for header actions which is causing transition on focus
shift.

This is introduced with
#10836 where outline
exclusion from transition is ignored in Tailwind util.

BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants