-
Notifications
You must be signed in to change notification settings - Fork 80
feat: deprecate widthScale/heightScale in favor of width/height #10786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate widthScale/heightScale in favor of width/height #10786
Conversation
fbddf02
to
df2138b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, @Elijbet! 🎉
Before merging, could you update the PR to only list components with width/height-prop-related updates?
The commit type might also need to be feat
since we’re adding new properties for consistency. If there weren’t new props involved, deprecate
would’ve been perfect. @geospatialem @DitwanP
Once the comments are addressed, this should be good to go!
Actually, we could leave this as is and use commit overrides to follow the steps outlined here. Sidebar: @DitwanP is the above recommendation in our internal doc? I wasn't able find it. |
We could indeed have the commit type as feat and then add a deprecation commit message to the body in order to list that separately on the changelog if that's what you're asking. And here's the link to the wiki section that covers this. |
@DitwanP Thanks for the link! |
**Related Issue:** #6172 ## Summary Refactor to consolidate `width/height` and `widthScale/heightScale` into a single property `width` with `s / m / l / auto / full` as options, and `height` with `s / m / l`. Deprecate `widthScale` and `heightScale` properties and the `half` value. Components addressed: - `button` - `dialog` - `dropdown` - `notice` - `segmented-control` - `select` - `sheet` - `shell-panel` - `split-button` deprecate: deprecate widthScale/heightScale properties in favor of width/height.
Related Issue: #6172
Summary
Refactor to consolidate
width/height
andwidthScale/heightScale
into a single propertywidth
withs / m / l / auto / full
as options, andheight
withs / m / l
. DeprecatewidthScale
andheightScale
properties and thehalf
value.Components addressed:
button
dialog
dropdown
notice
segmented-control
select
sheet
shell-panel
split-button
deprecate: deprecate widthScale/heightScale properties in favor of width/height.