Skip to content

docs(links): fix remaining 404s in docs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

docs(links): fix remaining 404s in docs #98

merged 1 commit into from
Jan 4, 2018

Conversation

noahmulfinger
Copy link
Contributor

ISSUES CLOSED: #92

Removes the in-comment links for now. If we are going to have in-comment links in the future, it will have to be in a way that allows injecting a base url so it works locally and on the github pages.

@noahmulfinger noahmulfinger requested a review from jgravois January 4, 2018 21:56
@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3c9a0f0 on final-404s into 28a3cca on master.

@Esri Esri deleted a comment from coveralls Jan 4, 2018
jgravois
jgravois approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@jgravois jgravois merged commit ae59cd9 into master Jan 4, 2018
@jgravois jgravois deleted the final-404s branch January 4, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahmulfinger @coveralls @jgravois