Skip to content

fix: postMessage must send a Credential that is usable by JSSDK #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

dbouwman
Copy link
Member

In the 3.x -> 4.x transition, the structure returned as part of the postMessage auth flow changed. It needs to be shaped like a Credential that the JS SDK can use to instantiate an IdentityMgr

Have verified this in Hub

@gavinr-maps gavinr-maps requested a review from patrickarlt April 30, 2025 12:44
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The post messages stuff is pretty much owned by the Hub team and is a private API so I'm not sweating this too much.

@gavinr-maps gavinr-maps merged commit 082b1c6 into main Apr 30, 2025
2 checks passed
@gavinr-maps gavinr-maps deleted the b/post-message-sends-credential branch April 30, 2025 16:07
@gavinr-maps
Copy link
Contributor

Released in https://www.npmjs.com/package/@esri/arcgis-rest-request/v/4.4.1

tomwayson pushed a commit that referenced this pull request Apr 30, 2025
## @esri/arcgis-rest-request [4.4.1](https://github.com/Esri/arcgis-rest-js/compare/@esri/[email protected]...@esri/[email protected]) (2025-04-30)

### Bug Fixes

* postMessage must send a Credential that is usable by JSSDK ([#1223](#1223)) ([082b1c6](082b1c6))
COV-GIS pushed a commit to COV-GIS/arcgis-rest-js that referenced this pull request Apr 30, 2025
## [4.6.1](https://github.com/Esri/arcgis-rest-js/compare/@esri/[email protected]...@esri/[email protected]) (2025-04-30)

### Bug Fixes

* restore IUserRequestOptions.authentication: ArcGISIdentityManager ([057edf0](Esri@057edf0))
* **arcgis-rest-request:** appendCustomParams strips valid options ([Esri#1221](Esri#1221)) ([bd1aa9c](Esri@bd1aa9c))
* postMessage must send a Credential that is usable by JSSDK ([Esri#1223](Esri#1223)) ([082b1c6](Esri@082b1c6))
* restore IUserRequestOptions.authentication to a ArcGISIdentityManager ([4c528ba](Esri@4c528ba))

### Features

* **arcgis-rest-request:** change getDomainCredentials to handle URLs with mismatching cases ([013e4da](Esri@013e4da))
* **arcgis-rest-request:** switched to using toLowerCase ([7ae474b](Esri@7ae474b))

### Reverts

* **arcgis-rest-feature-service:** service def fns take IAuthenticatedRequestOptions ([4471fff](Esri@4471fff))
tomwayson added a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants