fix: add token property to IAuthenticationManager #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwayson
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Thanks @patrickarlt
This LGTM, and once merged should enable Hub to upgrade to the latest version of rest-js packages w/o a major re-write of session.token -> await session.getToken().
The only thing I wonder about is that I don't believe this addresses either of the "weird" issues that you bring up in #1209 (comment)
Maybe you plan to address those at a later juncture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issues in #1209 by adding the
tokengetter back toIAuthenticationManager.`IUserAuthe