feat(arcgis-rest-request): change getDomainCredentials to handle URLs… #1211
Conversation
… with mismatching cases
| url = url.toLocaleLowerCase(); | ||
| return this.trustedDomains.some((domainWithProtocol) => { | ||
| return url.startsWith(domainWithProtocol); | ||
| return url.startsWith(domainWithProtocol.toLocaleLowerCase()); |
There was a problem hiding this comment.
Are you using .toLocaleLowerCase() (vs .toLowerCase) intentionally here? I'm wondering what are the potential implications vs using .toLowerCase().
There was a problem hiding this comment.
Yes. I'd read a comment that toLowerCase may not work properly for locales such as Turkish. I'll ask the translation team for advice.
String.prototype.toLocaleLowerCase():
Unlike other methods that use the locales argument, toLocaleLowerCase() does not allow locale matching. Therefore, after checking the validity of the locales argument, toLocaleLowerCase() always uses the first locale in the list (or the default locale if the list is empty), even if this locale is not supported by the implementation.
There was a problem hiding this comment.
For domain names (which we are checking here) should it really matter because the character set of so limited I think we can use toLowerCase() here.
MikeTschudi
deleted the
1210-support-domain-case-insensitivity-in-getdomaincredentials
branch
… with mismatching cases
#1210