Throw exception if output buffer size is greater than max buffer size

[WilliamDo]

Currently, the Output class allows the initial buffer size to be greater than the max buffer size. In some cases, we can observe an ArrayIndexOutOfBoundsException during an attempt to expand the buffer. The following test cases demonstrate the behaviour.

    @Test
    public void testNewOutputMaxBufferSizeLessThanBufferSize() {
        int bufferSize = 2;
        int maxBufferSize = 1;

        Output output = new Output(bufferSize, maxBufferSize);

        for (int i = 0; i < bufferSize; i++) {
            output.writeByte(0);
        }

        output.writeByte(0);

    }

    @Test
    public void testSetOutputMaxBufferSizeLessThanBufferSize() {
        int bufferSize = 2;
        int maxBufferSize = 1;

        Output output = new Output(bufferSize, bufferSize);
        output.setBuffer(new byte[bufferSize], maxBufferSize);

        for (int i = 0; i < bufferSize; i++) {
            output.writeByte(0);
        }

        output.writeByte(0);

    }

Suggestion is to throw an IllegalArgumentException when setting the buffer sizes to pre-empt this error.

[magro]

LGTM. Only the test might go into InputOutputTest.java, right?

[WilliamDo]

Yes that makes sense. Moved the tests and as a result, also found my mistake with maxBufferSize=-1 which is valid case being less than the initial buffer size. I've also updated the code for this.

[magro]

Cool. Can you squash the commits? Then I'll merge. Thanks!

[WilliamDo]

No worries, all done.

[magro]

Thanks!