Remove Patatoides for further memory optimisation #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because otherwise we don't draw the current position lol
Indirectly fixes #50 Storing the patatoides object takes a lot of memory, and is slightly unnecessary. We can fetch the previous positions from EuroScope and just render aircraft on those. Downside to this approach is that afterglows keep jiggling due to the randomness. Thus, we disable randomness on afterglows. We could do a workaround where we save the random seed for afterglows to keep some form of randomness, but this seems unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Patatoides map previously held bitmaps of previous aircraft primary radar returns as to draw the afterglow.
This takes a lot of memory. A previous MR tried to optimise this by cleaning up entries for aircraft that are no longer necessary,
but we can also just not store this.
The tradeoffs are explained in the commit messages, but it overall reduces memory useage just by vSMR in a test scenario based on the ELLX WorldFlight event over several hours from 2GiB to less than 200MiB. Woo