Skip to content

Adding an STV question to the seeder + count of abstentions to details #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2025
Merged

Adding an STV question to the seeder + count of abstentions to details #711

merged 4 commits into from
Feb 13, 2025

Conversation

viktorcsimma
Copy link
Contributor

The only problem is that votes are not linked to any user; so the number of ballots is not correct.

See the blockquote under the Details part for those enhancements.

grafik

@viktorcsimma viktorcsimma requested a review from a team as a code owner February 13, 2025 14:02
@deepsource-autofix
style: format code with PHP CS Fixer
2f85b40 
This commit fixes the style issues introduced in 794c626 according to the output
from PHP CS Fixer.

Details: #711
horcsinbalint
horcsinbalint requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@horcsinbalint horcsinbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has bugs, won't merge today

@horcsinbalint horcsinbalint merged commit 17774e0 into voting Feb 13, 2025
1 of 3 checks passed
horcsinbalint pushed a commit that referenced this pull request Feb 13, 2025
@deepsource-autofix @horcsinbalint
style: format code with PHP CS Fixer
3bcc077 
This commit fixes the style issues introduced in 794c626 according to the output
from PHP CS Fixer.

Details: #711
@horcsinbalint horcsinbalint deleted the voting-seeder branch February 13, 2025 15:31
horcsinbalint pushed a commit that referenced this pull request Feb 13, 2025
@deepsource-autofix @horcsinbalint
style: format code with PHP CS Fixer
e84e0db 
This commit fixes the style issues introduced in 794c626 according to the output
from PHP CS Fixer.

Details: #711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horcsinbalint horcsinbalint horcsinbalint requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktorcsimma @horcsinbalint