Skip to content

Fixing checkbox not remembering its previous state; as well as too short question titles #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fixing checkbox not remembering its previous state; as well as too short question titles #564

merged 1 commit into from
Jul 19, 2024

Conversation

viktorcsimma
Copy link
Contributor

As the title says.

The solution for the anonymous questions card is not too elegant (probably the custom id causes some complications), but it seems to work for now.

@viktorcsimma viktorcsimma added the bug Something isn't working label Jul 10, 2024
@viktorcsimma viktorcsimma self-assigned this Jul 10, 2024
@viktorcsimma viktorcsimma requested a review from a team as a code owner July 10, 2024 08:22
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 10, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates centre around refining the handling of checkbox inputs and extending the character limit for text inputs within three Blade PHP view files. The checkbox logic was improved to ensure the correct state is maintained based on the old array values, enhancing user experience during form submissions. Additionally, the maxlength attribute for a text input was expanded to accommodate longer text entries.

Changes

File Path Change Summary
resources/views/components/input/checkbox.blade.php Updated logic for setting the checkbox as checked based on the presence of a value in the old array.
resources/views/secretariat/evaluation-form/anonymous_questions.blade.php Improved handling of checkbox inputs by adjusting the :name and :id attributes, and refining the :checked attribute logic.
resources/views/utils/question_card.blade.php Increased the maxlength attribute of the text input with id "title" from 100 to 250.
Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a336db9 and baeddcc.

Files selected for processing (3)
  • resources/views/components/input/checkbox.blade.php (1 hunks)
  • resources/views/secretariat/evaluation-form/anonymous_questions.blade.php (1 hunks)
  • resources/views/utils/question_card.blade.php (1 hunks)
Additional comments not posted (3)
resources/views/components/input/checkbox.blade.php (1)

11-12: LGTM! Checkbox state handling improved.

The change ensures that the checkbox state accurately reflects previously submitted form data, addressing the issue of checkboxes not retaining their state.

resources/views/utils/question_card.blade.php (1)

12-12: LGTM! Increased maxlength for question titles.

The change increases the maxlength attribute from 100 to 250, allowing for longer input text in the title field. This addresses the issue of short question titles.

resources/views/secretariat/evaluation-form/anonymous_questions.blade.php (1)

34-36: LGTM! Improved checkbox handling with custom IDs.

The addition of the :id attribute uniquely identifies each checkbox, and the updated :checked logic ensures that the checkbox state accurately reflects prior inputs. This addresses the issue of checkboxes not retaining their state.

However, ensure that the usage of the :id attribute is consistent throughout the codebase.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kdmnk
kdmnk reviewed Jul 11, 2024
View reviewed changes
resources/views/components/input/checkbox.blade.php
@@ -8,7 +8,8 @@
'class' => "filled-in checkbox-color",
'name' => $id
])}}
@checked(old($id) || $checked)
@checked(in_array($attributes['value'], (old($id)['option'] ?? []))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this with the other checkbox instances?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; with the "remember me" field and voting, it seems to work.

@kdmnk kdmnk merged commit e5c49d2 into development Jul 19, 2024
6 checks passed
@kdmnk kdmnk deleted the checkbox-fix branch July 19, 2024 14:38
@coderabbitai coderabbitai bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmnk kdmnk kdmnk approved these changes

Assignees

@viktorcsimma viktorcsimma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktorcsimma @kdmnk