Use periodic events for KKT/Netreg #646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorcsimma
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
This seems to be a good idea:) take a look at these small things; then it's fine to merge into #555 and handle together with it.
| @@ -57,7 +41,7 @@ | |||
| if (value) { | |||
| value = moment(value).format("YYYY. MM. DD. HH:mm"); | |||
| } else { | |||
| value = 'Nincs hozzáférés' | |||
| value = 'N/A' | |||
There was a problem hiding this comment.
It could be something like 'Unlimited until next kkt period' for those having paid kkt; it would be easier to understand.
kdmnk
force-pushed
the
decouple-periodic-events
branch
from
16f35dc to
72951eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some thing that was missing before.
I'm merging to #555, you can check both PRs.
When a KKT/Netreg period opens, now the collegists 'netreg_paid' will be set to false, and they have internet only until the payment deadline. If they pay, the netreg_paid=true will overwrite the deadline.