Skip to content

Commit 16f35dc

Browse files
committed
fix test
1 parent 6708b20 commit 16f35dc

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

app/Console/Commands/FinalizeSemesterEvaluation.php

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
use Illuminate\Console\Command;
66
use App\Http\Controllers\Secretariat\SemesterEvaluationController;
77
use Illuminate\Support\Facades\App;
8+
use Illuminate\Support\Facades\DB;
9+
use Illuminate\Support\Facades\Log;
10+
use Illuminate\Support\Facades\Mail;
811
use App\Models\Semester;
912

1013
class FinalizeSemesterEvaluation extends Command

app/Http/Controllers/Secretariat/SemesterEvaluationController.php

+8
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,14 @@ public function store(Request $request): RedirectResponse
176176
return back()->with('message', __('general.successful_modification'))->with('section', $request->section);
177177
}
178178

179+
/**
180+
* Return the list of users who haven't filled out the form.
181+
* It is calculated based on the students who haven't set their status for the next semester.
182+
* Seniors are ignored.
183+
*
184+
* @param Semester $semester
185+
* @return \Illuminate\Database\Eloquent\Collection|\Illuminate\Support\Collection
186+
*/
179187
public static function usersHaventFilledOutTheForm(Semester $semester)
180188
{
181189
return User::doesntHaveStatusFor($semester->succ())

0 commit comments

Comments
 (0)