Skip to content

wraps _parse_timeseries_generic and call it for each period #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ruupert
Copy link

@ruupert ruupert commented Oct 6, 2024

Understood from #346 that the API now returns each day as a different period with each period having the same index numbers.

So I figured that the easiest way is to just wrap the old function slightly modified and call it as many times there are periods, and collect the series, combine them into a single series and then return it.

running "python -m test" did return 0.

@ruupert
Copy link
Author

ruupert commented Oct 6, 2024

this pr does have the resolution to pandas timeseries mapping problem which is fixed in #347 at

parsers.py:
freq_key = _timeseries_frequencies_to_timedelta(soup_series.index.freqstr)
series_parsers.py:
def _timeseries_frequencies_to_timedelta(freq_text: str) -> str:

@ruupert ruupert closed this Oct 6, 2024
@ruupert
Copy link
Author

ruupert commented Oct 6, 2024

this with the time_mapping in parse_prices() from issue this solution works but logically _parse_timeseries_generic() should just parse like it says in the name, not return a resulting series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant