Skip to content

Update PerformanceAPI version and add supprot for ARM binaries #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

nathanvoglsam
Copy link
Contributor

This updates the binaries to the latest versions and adds support for the arm64 and arm64ec binaries.

Feel free to grab the binaries from your own install though, no need to trust mine. The source changes in the build.rs should be correct though.

@AlexEne
Copy link

AlexEne commented Apr 25, 2025

Hi, since this is probably not going to get merged, would you mind publishing this under superluminal-perf-rs-v2 and once it's on crates io i can raise a PR (or you can if you want to) for profiling to take it as a dependency?

@fu5ha
Copy link
Member

fu5ha commented Apr 30, 2025

I am not the best person for this as I haven't touched this crate personally and don't use it but I do have the power. If someone can give an approving review that this is working as expected I can merge it and do a new cargo release as well

@AlexEne
Copy link

AlexEne commented May 6, 2025

I can confirm this works, tested just now.
I had to add a static on SuperluminalGuard here: profiling\profiling\src\superluminal_impl.rs

Once this is merged and a new release published, I can raise a PR to profiling crate to fix it up (it needs these changes: https://github.com/AlexEne/profiling

@mergify mergify bot merged commit 60348e8 into EmbarkStudios:main May 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants