Fix for hang due to mp.Pool in bootstrap_stderr #3135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mp.pool created in bootstrap_stderr is not joined with pool.join() after it is finished, causing a hang-like situtation when too many processes get spawned.
From the documentation at https://docs.python.org/3/library/multiprocessing.html#multiprocessing.pool.Pool.join,
Pool.close() only lets pool know to stop accepting further multiprocess requests. In absence of join, the resources are not relinquished.
Starting Python >= 3.3, Pool supports CM protocol.
Replaced existing implementation with a mp.pool CM to automatically handle pool.close() and pool.join().