Skip to content

Prepare 23.2.5 rc1 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
52b92b8
Cherry-pick <https://github.com/bitcoin/bitcoin/pull/27122>
roconnor-blockstream Feb 17, 2023
5224c1a
Exclude simplicity directory
roconnor-blockstream Apr 18, 2023
f502c24
Squashed 'src/simplicity/' content from commit 86ac0f92c4
roconnor-blockstream Oct 7, 2024
8760cdd
Merge commit 'f502c24196d23b74c2c402911ecc3a6839101557' as 'src/simpl…
roconnor-blockstream Oct 7, 2024
d5ad21b
Lint simplicity subtree
roconnor-blockstream Sep 17, 2024
28553fd
Add Simplicity to the build system.
roconnor-blockstream Feb 23, 2023
6c69253
Add MSVC build configuration for libelementssimplicity
roconnor-blockstream Sep 18, 2024
50916cf
simplicity: enable coverage in configure.ac
delta1 Apr 16, 2024
96fb8f5
Store hash_genesis_block in PrecomputedTransactionData.
roconnor-blockstream Feb 22, 2023
1698454
Add Simplicity verification
roconnor-blockstream Jun 10, 2024
bcd508f
Add Simplicity Deployment structure
roconnor-blockstream Feb 23, 2023
afee926
Simplicity Functional Tests.
roconnor-blockstream Jun 11, 2024
4ca2411
Asset tests: Parse Elements script errors
roconnor-blockstream Jun 12, 2024
5088360
Asset tests: Check script error
uncomputable Oct 29, 2023
2534141
Merge ElementsProject/elements#1219: Simplicity
apoelstra Oct 7, 2024
2f2f3aa
link: add simplicity to bitcoin-chainstate binary
apoelstra Oct 8, 2024
850b820
disable simplicity on regtest
apoelstra Oct 7, 2024
3621e7a
liquid testnet: enable simplicity at all times
apoelstra Oct 7, 2024
2532c4a
rpc: add simplicity to `getdeploymentinfo`
apoelstra Oct 7, 2024
57ab101
simplicity: copy activation threshold/period from taproot
apoelstra Oct 7, 2024
626e3ae
test: add functional simplicity activation test
apoelstra Oct 7, 2024
aa2420c
Merge pull request #1368 from apoelstra/2024-10--simplicity-activation
delta1 Oct 8, 2024
7398cfa
Use LBTC instead of L-BTC in QT
psgreco Nov 4, 2024
60cf64e
Merge pull request #1374 from psgreco/master-lbtc
delta1 Nov 18, 2024
5438960
Revert "Merge pull request #1368 from apoelstra/2024-10--simplicity-a…
psgreco Nov 18, 2024
adb4478
Revert "Merge ElementsProject/elements#1219: Simplicity"
psgreco Nov 18, 2024
c7412de
Merge branch 'master-nosimplicity' into elem-23.2.5-rc1
psgreco Nov 18, 2024
1e8a7cb
Merge branch 'master' into elem-23.2.5-rc1
psgreco Nov 18, 2024
0abcf8d
Bump version to 23.2.5-rc1
psgreco Nov 18, 2024
7622638
Update manpages
psgreco Nov 18, 2024
22cc8df
Accept by default discountct in liquidv1
psgreco Nov 4, 2024
5de3924
Update help text for "acceptdiscountct"
psgreco Nov 4, 2024
cc2ecbb
Merge pull request #1378 from psgreco/master-discountct-liquidv1
delta1 Dec 17, 2024
081e121
Merge branch 'master' into elem-23.2.5-rc1
psgreco Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
AC_PREREQ([2.69])
define(_CLIENT_VERSION_MAJOR, 23)
define(_CLIENT_VERSION_MINOR, 2)
define(_CLIENT_VERSION_BUILD, 4)
define(_CLIENT_VERSION_RC, 0)
define(_CLIENT_VERSION_BUILD, 5)
define(_CLIENT_VERSION_RC, 1)
define(_CLIENT_VERSION_IS_RELEASE, true)
define(_COPYRIGHT_YEAR, 2024)
define(_COPYRIGHT_HOLDERS,[The %s developers])
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elements-cli.1
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTS-CLI "1" "August 2024" "elements-cli v23.2.3" "User Commands"
.TH ELEMENTS-CLI "1" "November 2024" "elements-cli v23.2.5" "User Commands"
.SH NAME
elements-cli \- manual page for elements-cli v23.2.3
elements-cli \- manual page for elements-cli v23.2.5
.SH SYNOPSIS
.B elements-cli
[\fI\,options\/\fR] \fI\,<command> \/\fR[\fI\,params\/\fR] \fI\,Send command to Elements Core\/\fR
Expand All @@ -15,7 +15,7 @@ elements-cli \- manual page for elements-cli v23.2.3
.B elements-cli
[\fI\,options\/\fR] \fI\,help <command> Get help for a command\/\fR
.SH DESCRIPTION
Elements Core RPC client version v23.2.3
Elements Core RPC client version v23.2.5
.SH OPTIONS
.HP
\-?
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elements-qt.1
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTS-QT "1" "August 2024" "elements-qt v23.2.3" "User Commands"
.TH ELEMENTS-QT "1" "November 2024" "elements-qt v23.2.5" "User Commands"
.SH NAME
elements-qt \- manual page for elements-qt v23.2.3
elements-qt \- manual page for elements-qt v23.2.5
.SH SYNOPSIS
.B elements-qt
[\fI\,command-line options\/\fR]
.SH DESCRIPTION
Elements Core version v23.2.3
Elements Core version v23.2.5
.SH OPTIONS
.HP
\-?
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elements-tx.1
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTS-TX "1" "August 2024" "elements-tx v23.2.3" "User Commands"
.TH ELEMENTS-TX "1" "November 2024" "elements-tx v23.2.5" "User Commands"
.SH NAME
elements-tx \- manual page for elements-tx v23.2.3
elements-tx \- manual page for elements-tx v23.2.5
.SH SYNOPSIS
.B elements-tx
[\fI\,options\/\fR] \fI\,<hex-tx> \/\fR[\fI\,commands\/\fR] \fI\,Update hex-encoded Elements transaction\/\fR
.br
.B elements-tx
[\fI\,options\/\fR] \fI\,-create \/\fR[\fI\,commands\/\fR] \fI\,Create hex-encoded Elements transaction\/\fR
.SH DESCRIPTION
Elements Core elements\-tx utility version v23.2.3
Elements Core elements\-tx utility version v23.2.5
.SH OPTIONS
.HP
\-?
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elements-util.1
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTS-UTIL "1" "August 2024" "elements-util v23.2.3" "User Commands"
.TH ELEMENTS-UTIL "1" "November 2024" "elements-util v23.2.5" "User Commands"
.SH NAME
elements-util \- manual page for elements-util v23.2.3
elements-util \- manual page for elements-util v23.2.5
.SH SYNOPSIS
.B bitcoin-util
[\fI\,options\/\fR] [\fI\,commands\/\fR] \fI\,Do stuff\/\fR
.SH DESCRIPTION
Elements Core bitcoin\-util utility version v23.2.3
Elements Core bitcoin\-util utility version v23.2.5
.SH OPTIONS
.HP
\-?
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elements-wallet.1
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTS-WALLET "1" "August 2024" "elements-wallet v23.2.3" "User Commands"
.TH ELEMENTS-WALLET "1" "November 2024" "elements-wallet v23.2.5" "User Commands"
.SH NAME
elements-wallet \- manual page for elements-wallet v23.2.3
elements-wallet \- manual page for elements-wallet v23.2.5
.SH DESCRIPTION
Elements Core elements\-wallet version v23.2.3
Elements Core elements\-wallet version v23.2.5
.PP
elements\-wallet is an offline tool for creating and interacting with Elements Core wallet files.
By default elements\-wallet will act on wallets in the default mainnet wallet directory in the datadir.
Expand Down
6 changes: 3 additions & 3 deletions doc/man/elementsd.1
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3.
.TH ELEMENTSD "1" "August 2024" "elementsd v23.2.3" "User Commands"
.TH ELEMENTSD "1" "November 2024" "elementsd v23.2.5" "User Commands"
.SH NAME
elementsd \- manual page for elementsd v23.2.3
elementsd \- manual page for elementsd v23.2.5
.SH SYNOPSIS
.B elementsd
[\fI\,options\/\fR] \fI\,Start Elements Core\/\fR
.SH DESCRIPTION
Elements Core version v23.2.3
Elements Core version v23.2.5
.SH OPTIONS
.HP
\-?
Expand Down
2 changes: 1 addition & 1 deletion src/chainparams.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ class CLiquidV1Params : public CChainParams {

multi_data_permitted = true;
create_discount_ct = args.GetBoolArg("-creatediscountct", false);
accept_discount_ct = args.GetBoolArg("-acceptdiscountct", false) || create_discount_ct;
accept_discount_ct = args.GetBoolArg("-acceptdiscountct", true) || create_discount_ct;

parentGenesisBlockHash = uint256S("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f");
const bool parent_genesis_is_null = parentGenesisBlockHash == uint256();
Expand Down
2 changes: 1 addition & 1 deletion src/init.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ void SetupServerArgs(ArgsManager& argsman)
argsman.AddArg("-initialreissuancetokens=<n>", "The amount of reissuance tokens created in the genesis block. (default: 0)", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
argsman.AddArg("-ct_bits", strprintf("The default number of hiding bits in a rangeproof. Will be exceeded to cover amounts exceeding the maximum hiding value. (default: %d)", 52), ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
argsman.AddArg("-ct_exponent", strprintf("The hiding exponent. (default: %s)", 0), ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
argsman.AddArg("-acceptdiscountct", "Accept discounted fees for Confidential Transactions (default: false)", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
argsman.AddArg("-acceptdiscountct", "Accept discounted fees for Confidential Transactions (default: true in liquidtestnet and liquidv1, false otherwise)", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);
argsman.AddArg("-creatediscountct", "Create Confidential Transactions with discounted fees (default: false). Setting this to true will also set 'acceptdiscountct' to true.", ArgsManager::ALLOW_ANY, OptionsCategory::CHAINPARAMS);

#if defined(USE_SYSCALL_SANDBOX)
Expand Down
12 changes: 6 additions & 6 deletions src/qt/bitcoinunits.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ QString BitcoinUnits::longName(int unit)
}
switch(unit)
{
case BTC: return QString("L-BTC");
case mBTC: return QString("mL-BTC");
case uBTC: return QString::fromUtf8("μL-BTC");
case SAT: return QString("Satoshi (L-sat)");
case BTC: return QString("LBTC");
case mBTC: return QString("mLBTC");
case uBTC: return QString::fromUtf8("μLBTC");
case SAT: return QString("Satoshi (Lsat)");
default: return QString("???");
}
}
Expand All @@ -75,8 +75,8 @@ QString BitcoinUnits::shortName(int unit)
}
switch(unit)
{
case uBTC: return QString::fromUtf8("L-bits");
case SAT: return QString("L-sat");
case uBTC: return QString::fromUtf8("Lbits");
case SAT: return QString("Lsat");
default: return longName(unit);
}
}
Expand Down