Skip to content

Simplicity #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Simplicity #1219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
52b92b8
Cherry-pick <https://github.com/bitcoin/bitcoin/pull/27122>
roconnor-blockstream Feb 17, 2023
5224c1a
Exclude simplicity directory
roconnor-blockstream Apr 18, 2023
f502c24
Squashed 'src/simplicity/' content from commit 86ac0f92c4
roconnor-blockstream Oct 7, 2024
8760cdd
Merge commit 'f502c24196d23b74c2c402911ecc3a6839101557' as 'src/simpl…
roconnor-blockstream Oct 7, 2024
d5ad21b
Lint simplicity subtree
roconnor-blockstream Sep 17, 2024
28553fd
Add Simplicity to the build system.
roconnor-blockstream Feb 23, 2023
6c69253
Add MSVC build configuration for libelementssimplicity
roconnor-blockstream Sep 18, 2024
50916cf
simplicity: enable coverage in configure.ac
delta1 Apr 16, 2024
96fb8f5
Store hash_genesis_block in PrecomputedTransactionData.
roconnor-blockstream Feb 22, 2023
1698454
Add Simplicity verification
roconnor-blockstream Jun 10, 2024
bcd508f
Add Simplicity Deployment structure
roconnor-blockstream Feb 23, 2023
afee926
Simplicity Functional Tests.
roconnor-blockstream Jun 11, 2024
4ca2411
Asset tests: Parse Elements script errors
roconnor-blockstream Jun 12, 2024
5088360
Asset tests: Check script error
uncomputable Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ LCOV_FILTER_PATTERN = \
-p "src/crypto/ctaes" \
-p "src/minisketch" \
-p "src/secp256k1" \
-p "src/simplicity/secp256k1" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 50916cf:

Probably we didn't want to filter this. (I'm kinda surprised that the upstream libsecp is filtered. But I guess they have their own coverage analysis.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, we should stick /nix/store into this list and src/include/boost. I'm not sure why we need to do this and Bitcoin doesn't (well, the answer is "NixOS") but it's harmless and helpful for Russell and me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little hesitant to add nix-specific fixes here, and rather just patch the file in https://github.com/roconnor-blockstream/elements-nix/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed src/simplicity/secp256k1 from the filter as part of #1390.

-p "depends"

DIR_FUZZ_SEED_CORPUS ?= qa-assets/fuzz_seed_corpus
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ if test "$use_lcov" = "yes"; then

AX_CHECK_LINK_FLAG([--coverage], [LDFLAGS="$LDFLAGS --coverage"],
[AC_MSG_ERROR([lcov testing requested but --coverage linker flag does not work])])
AX_CHECK_COMPILE_FLAG([--coverage],[CXXFLAGS="$CXXFLAGS --coverage"],
AX_CHECK_COMPILE_FLAG([--coverage],[CXXFLAGS="$CXXFLAGS --coverage";CFLAGS="$CFLAGS --coverage"],
[AC_MSG_ERROR([lcov testing requested but --coverage flag does not work])])
CXXFLAGS="$CXXFLAGS -Og"
fi
Expand Down