Skip to content

Improve elements memory usage #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 26, 2023
Merged

Improve elements memory usage #1190

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
68eb086
Refactor CBlockIndex to make proof and dynafed fields optional.
gwillen Nov 8, 2022
7c55557
Add a flag for header-trimming; clear P2P network feature bits when e…
gwillen Nov 8, 2022
eff6be3
Trim headers when loading block index from disk.
gwillen Nov 8, 2022
4f0da3c
Trim headers when flushing to disk, and reduce flush interval from 1h…
gwillen Nov 8, 2022
f5c7995
When people ask us for headers we do not have (over REST or RPC), do …
gwillen Nov 10, 2022
7e6fe4a
Don't let header syncing get too far ahead of block syncing
gwillen Nov 15, 2022
a2db974
Fix false-positive lint
gwillen Nov 15, 2022
763d298
Fix deserialization issues in certain functional tests
gwillen Nov 16, 2022
394e59d
Politely and safely refuse getheaders requests for headers we have tr…
gwillen Nov 23, 2022
fba37b7
Move enough-headers check up, rejecting excess headers when received.
gwillen Dec 7, 2022
29345e9
pgreco's startup crash fix
gwillen Dec 7, 2022
b9b7f65
Apply suggestions from code review
gwillen Jan 4, 2023
8cad8cd
Further fixes from code review
gwillen Jan 5, 2023
e8475e7
Fix stuck IBD when discarding unwanted headers from peers.
gwillen Jan 25, 2023
e622156
Update documentation
gwillen Jan 25, 2023
15dbe64
Remove stray comment
gwillen Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/net_processing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3166,10 +3166,17 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
LogPrint(BCLog::NET, "getheaders %d to %s from peer=%d\n", (pindex ? pindex->nHeight : -1), hashStop.IsNull() ? "end" : hashStop.ToString(), pfrom.GetId());
for (; pindex; pindex = m_chainman.ActiveChain().Next(pindex))
{
if (pindex->trimmed()) {
// For simplicity, if any of the headers they're asking for are trimmed,
// just drop the request.
LogPrint(BCLog::NET, "%s: ignoring getheaders from peer=%i which would return at least one trimmed header\n", __func__, pfrom.GetId());
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the GETHEADERS message.

Does the GETBLOCK message still work fine if the headers are not in memory? I have not tested it. It doesn't appear that this call needs in-memory headers to find blocks from the index, but I just want to confirm.

Copy link
Contributor Author

@gwillen gwillen Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this specific case other than by running against the live network. But I systematically checked for references to the trimmed fields, so I should have caught this if it were an issue. Looking at it now, I can see that it never calls GetBlockHeader (which is the usual suspect) or any of the other offending methods -- it calls ReadBlockFromDisk, which is safe.

}
vHeaders.push_back(pindex->GetBlockHeader());
if (--nLimit <= 0 || pindex->GetBlockHash() == hashStop)
break;
}

// pindex can be nullptr either if we sent m_chainman.ActiveChain().Tip() OR
// if our peer has m_chainman.ActiveChain().Tip() (and thus we are sending an empty
// headers message). In both cases it's safe to update
Expand Down