Add crosschain asset 'STAR' supporting for aptos #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ValentineReese
commented
Dec 8, 2022
ValentineReese
commented
- Add crosschain asset 'STAR' supporting for aptos
- Reformat some codes.
2. Reformat some codes.
element2050
reviewed
Dec 9, 2022
|
|
||
| [addresses] | ||
| StarcoinFramework = "0x1" | ||
| Bridge = "0xe52552637c5897a2d499fbf08216f73e" | ||
| SwapAdmin = "0x8c109349c6bd91411d6bc962e080c4a3" |
There was a problem hiding this comment.
Swap项目依赖Bridge，如果Bridge又依赖Swap，就成双向依赖，貌似Move里双向依赖会有问题？
There was a problem hiding this comment.
这里只是简单的把地址放进来了，没有实际依赖，因为需要依赖asset
element2050
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.