Skip to content

Support .NET 8, bump System.Text.Json from 6.0.0 to non-vulnerable 8.0.5 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 24, 2025

Conversation

inikulshin
Copy link
Contributor

@inikulshin inikulshin commented Feb 23, 2025

I extracted non-API changes from #349 to separate PR.

@inikulshin
Copy link
Contributor Author

I tried to run integration tests on Windows, bug gave up:

docker-library/rabbitmq#168 (comment)

@inikulshin
Copy link
Contributor Author

I also downgraded Microsoft.CodeAnalysis.CSharp to 4.8.0:

@Pliner you removed CodeQL workflow 2 years ago (6af477f), but it's still active:

https://github.com/EasyNetQ/EasyNetQ.Management.Client/actions/workflows/github-code-scanning/codeql

Was it intended?

  • For this PR (and last few months) CodeQL workflow fails because it uses old MSBuild:
  [2025-02-20 20:37:30] [build-stdout] Running dotnet clean /home/runner/work/EasyNetQ.Management.Client/EasyNetQ.Management.Client/Source/EasyNetQ.Management.Client.sln
  [2025-02-20 20:37:30] [build-stdout] MSBuild version 17.8.5+b5265ef37 for .NET

Since #323, MSBuild version must be >= 17.9, according to

https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md#versioning

@zidad FYI

@lukebakken
Copy link

I tried to run integration tests on Windows

Install Erlang and RabbitMQ via their .exe installers in the same manner as RabbitMQ.Client:

@zidad zidad merged commit 891eee7 into master Feb 24, 2025
9 checks passed
@zidad zidad deleted the master-bump branch February 24, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants