Skip to content

Add new Graph and remove old graph component #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 23, 2025
Merged

Conversation

haideriqbal
Copy link
Collaborator

No description provided.

@haideriqbal haideriqbal requested a review from Copilot April 10, 2025 22:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • frontend/index.html.in: Language not supported
  • frontend/package.json: Language not supported
Comments suppressed due to low confidence (1)

frontend/src/pages/ontologies/entities/graphRenderers/nodeRenderer.ts:220

  • The use of ctx.roundRect may not be supported in all target browsers; consider adding a polyfill or fallback implementation if legacy browser support is required.
ctx.roundRect(

}, [selectedEntity, entityType]);

// Handle node selection in the graph
const handleNodeSelect = useCallback((entity) => {
Copy link
Preview

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useCallback hook for handleNodeSelect uses an empty dependency array while referencing updateSelectedEntity and ontologyId. Please add these dependencies to avoid stale closures.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

@henrietteharmse henrietteharmse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jamesamcl
Copy link
Member

Awesome

@haideriqbal haideriqbal merged commit 2e82248 into dev Apr 23, 2025
1 check passed
@haideriqbal haideriqbal deleted the replace-graph-view branch April 23, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants