Skip to content

Creates proxy TLS secret in the runtime #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Creates proxy TLS secret in the runtime #4774

merged 1 commit into from
Apr 22, 2025

Conversation

aorcholski
Copy link
Contributor

@aorcholski aorcholski commented Apr 16, 2025 •
edited
Loading

JIRA

Description

Proxy TLS certificate and private key are created in the runtime.

Hardcoded proxy secret and proxy certificate (custom.pem) removed from the repository.

How can this be tested?

make test/e2e/cloudnative/codemodules-with-proxy-custom-ca-ag-cert
make test/e2e/cloudnative/codemodules-with-proxy-custom-ca-auto-ag-cert

@aorcholski aorcholski added the test Changes to or additional e2e/regression tests label Apr 16, 2025
@aorcholski aorcholski force-pushed the feature/e2e-proxy-cert branch 2 times, most recently from ba3c96f to 3134ff6 Compare April 16, 2025 18:19
@aorcholski aorcholski marked this pull request as ready for review April 16, 2025 18:29
@aorcholski aorcholski requested a review from a team as a code owner April 16, 2025 18:29
@aorcholski aorcholski changed the title WIP Creates proxy TLS secret in the runtime Creates proxy TLS secret in the runtime Apr 16, 2025
@aorcholski aorcholski force-pushed the feature/e2e-proxy-cert branch from 3134ff6 to c47ffb2 Compare April 16, 2025 18:58
wepudt
wepudt approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@wepudt wepudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran in my cluster, code lgtm

@aorcholski aorcholski force-pushed the feature/e2e-proxy-cert branch from c47ffb2 to a34c3ae Compare April 18, 2025 11:05
@aorcholski aorcholski force-pushed the feature/e2e-proxy-cert branch from a34c3ae to 6ddefa7 Compare April 22, 2025 09:12
@aorcholski aorcholski merged commit 8f3ebda into main Apr 22, 2025
11 checks passed
@aorcholski aorcholski deleted the feature/e2e-proxy-cert branch April 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wepudt wepudt wepudt approved these changes

@andriisoldatenko andriisoldatenko Awaiting requested review from andriisoldatenko andriisoldatenko is a code owner automatically assigned from Dynatrace/kubernetes-operator

@Incredible-O Incredible-O Awaiting requested review from Incredible-O Incredible-O is a code owner automatically assigned from Dynatrace/kubernetes-operator

@gkrenn gkrenn Awaiting requested review from gkrenn gkrenn is a code owner automatically assigned from Dynatrace/kubernetes-operator

@0sewa0 0sewa0 Awaiting requested review from 0sewa0 0sewa0 is a code owner automatically assigned from Dynatrace/kubernetes-operator

@chrismuellner chrismuellner Awaiting requested review from chrismuellner chrismuellner is a code owner automatically assigned from Dynatrace/kubernetes-operator

@waodim waodim Awaiting requested review from waodim waodim is a code owner automatically assigned from Dynatrace/kubernetes-operator

@StefanHauth StefanHauth Awaiting requested review from StefanHauth StefanHauth is a code owner automatically assigned from Dynatrace/kubernetes-operator

Assignees
No one assigned
Labels
test Changes to or additional e2e/regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aorcholski @wepudt