Add fix for the sequence id ordering problem #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SequenceIds are currently ordered lexicographically, which is wrong as the SDC standards define no order on them. We hence order them by the timestamp of the first message that they were used in. # Checklist The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee **and** reviewer: * Adherence to coding conventions * [x] Pull Request Assignee * [x] Reviewer (midtuna) * Adherence to javadoc conventions * [x] Pull Request Assignee * [x] Reviewer (midtuna) * Changelog update (necessity checked and entry added or not added respectively) * [x] Pull Request Assignee * [x] Reviewer (midtuna) * README update (necessity checked and entry added or not added respectively) * [x] Pull Request Assignee * [x] Reviewer (midtuna) * config update (necessity checked and entry added or not added respectively) * [x] Pull Request Assignee * [x] Reviewer (midtuna) * SDCcc executable ran against a test device (if necessary) * [x] Pull Request Assignee * [x] Reviewer (midtuna) --------- Co-authored-by: midttuna <[email protected]> (cherry picked from commit 729356b) Signed-off-by: Malte Grebe-Lüth <[email protected]>
Added kotlin and detekt. (partly cherry picked from commit 4d84e9e) Signed-off-by: Malte Grebe-Lüth <[email protected]>
…ssageStorage.getOrderedStreamForQuery Signed-off-by: Malte Grebe-Lüth <[email protected]>
…ring Signed-off-by: Malte Grebe-Lüth <[email protected]>
Signed-off-by: Malte Grebe-Lüth <[email protected]>
Signed-off-by: Malte Grebe-Lüth <[email protected]>
maximilianpilz
requested changes
Jan 24, 2025
sdccc/src/main/java/com/draeger/medical/sdccc/messages/OrderedStreamIterator.kt
Outdated
Show resolved
Hide resolved
maximilianpilz
requested changes
Jan 24, 2025
sdccc/src/main/java/com/draeger/medical/sdccc/messages/MessageStorage.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Malte Grebe-Lüth <[email protected]>
maximilianpilz
requested changes
Jan 24, 2025
Signed-off-by: Malte Grebe-Lüth <[email protected]>
maximilianpilz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the fix for the issue 218 from the commit from the main branch.
Fixed other queries in MessageStorage that require ordering.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: