Skip to content

Specify https to specify new xsd location #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Nov 21, 2017

even if there is a redirection from http to https setup. The right url is with https.
The redirection is not well-handled by all editors (such as Eclipse) which making them failing to find the xsd.

Issue link

All PRs MUST have a corresponding issue linked and issue number in PR name. i.e.:

    [ISSUE: 101] My First PR

Purpose

Describe the problem or feature

Approach

How does this change address the problem?

Open Questions and Pre-Merge TODOs

  • Issue created
  • Unit tests pass
  • Documentation updated
  • Travis build passed

@garethahealy
Copy link
Collaborator

@apupier ; i know this will work, but can you add a unit test which loads a mapping that uses HTTPS URI. its just to confirm that the docs don't tell users to do something that doesn't actually work.

@garethahealy
Copy link
Collaborator

@apupier ; have you had chance to do the unit test?

@apupier
Copy link
Contributor Author

apupier commented Dec 5, 2017

@apupier ; have you had chance to do the unit test?

no not yet, I won't have time before Christmas for sure.

@apupier
Copy link
Contributor Author

apupier commented Jan 18, 2018

@garethahealy I provided a test similar to Version5XSDtest just checking that there is no exception when loading the file.
I think that ti would be best to have all examples and test files using the https instead of http but it means changing hundreds of lines so maybe in another in PR.

@@ -46,3 +46,10 @@ Just simply use the dozer-core:
<version>6.0.0</version>
</dependency>
----

=== 4. XSD namespace and location has been modified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this change. This doesnt apply to v6, it applies to v6.1, as per:

-->
<mappings xmlns="http://dozermapper.github.io/schema/bean-mapping"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://dozermapper.github.io/schema/bean-mapping https://dozermapper.github.io/schema/bean-mapping.xsd">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would of expected urls to be HTTPS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the namespace?
No, if we put https for the namespace, it means another namespace break.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense.

@garethahealy garethahealy merged commit fa40a9e into DozerMapper:master Feb 14, 2018
@apupier apupier deleted the patch-1 branch February 14, 2018 13:24
@apupier
Copy link
Contributor Author

apupier commented Feb 14, 2018

thanks for the review and the merge! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants