-
Notifications
You must be signed in to change notification settings - Fork 487
Specify https to specify new xsd location #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@apupier ; i know this will work, but can you add a unit test which loads a mapping that uses HTTPS URI. its just to confirm that the docs don't tell users to do something that doesn't actually work. |
@apupier ; have you had chance to do the unit test? |
no not yet, I won't have time before Christmas for sure. |
@garethahealy I provided a test similar to Version5XSDtest just checking that there is no exception when loading the file. |
@@ -46,3 +46,10 @@ Just simply use the dozer-core: | |||
<version>6.0.0</version> | |||
</dependency> | |||
---- | |||
|
|||
=== 4. XSD namespace and location has been modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this change. This doesnt apply to v6, it applies to v6.1, as per:
--> | ||
<mappings xmlns="http://dozermapper.github.io/schema/bean-mapping" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://dozermapper.github.io/schema/bean-mapping https://dozermapper.github.io/schema/bean-mapping.xsd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would of expected urls to be HTTPS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the namespace?
No, if we put https for the namespace, it means another namespace break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense.
…n guide Signed-off-by: Aurélien Pupier <[email protected]>
Signed-off-by: Aurélien Pupier <[email protected]>
thanks for the review and the merge! :-) |
even if there is a redirection from http to https setup. The right url is with https.
The redirection is not well-handled by all editors (such as Eclipse) which making them failing to find the xsd.
Issue link
All PRs MUST have a corresponding issue linked and issue number in PR name. i.e.:
Purpose
Describe the problem or feature
Approach
How does this change address the problem?
Open Questions and Pre-Merge TODOs