-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(ui): adjust tablist item width for compose services #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36fd3b2
to
204aea0
Compare
204aea0
to
d799b46
Compare
@Siumauricio this PR will hide Logs, Monitoring, Advanced tabs. Because with grid-col-7 it will be 2-row grid with overflow-y-hidden. Solutions is simple - just use display flex with overflow auto like Application does. I will send PR with improvements. |
Hi @gentslava, Regarding
Which operating system and browser are you using? I've tested on both Chrome and Zen/Firefox (on Linux + MacOS) and can't reproduce - unless I'm misunderstanding the issue. For example, here's what I see: output.webm |
Well I see you got display flex and grid-cols together for what? These are parameters in CSS that don't work with each other. |
The change was just copying the TabList from the application file to the compose file so that they're consistent, as mentioned in the original PR. If you're making an improvement to one, you should probably do the same for the other. Now, as per my response and video, the issue you've mentioned isn't reproducible on my end. Not saying it doesn't exist on some system and should not be fixed - this was why I asked for your operating system and browser to see if it can be reproduced. |
Yes, I made changes to both parts: to compose and to application. |
Nothing in your response to my comment containing the video "explained" that the original problem you reported, simply wasn't a problem. Either way, glad we now get a resolution on this, i.e. no tabs were actually hidden by the new code in this PR, which simply copies the code from application to compose to make them consistent and address the text overflow issue. |
This is indeed true. I have already explained that the initial report was due to human error (inattention):
So there are no complaints against you here. Just improving the layout of this part of the application. |
Looks like "Volume Backup" was introduced recently, causing some UI issues.
The changes here is to simply to use the same tab list logic in compose as applications.
Before
After