Skip to content

Minor file visitor refactoring #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Conversation

jeremystucki
Copy link
Member

@jeremystucki jeremystucki commented Mar 25, 2025

The diff looks enormous, but it really is mostly reduced nesting. If you look at it without whitespaces changes it looks a lot better.

Feel free to close without merging if this causes too much noise.

@jeremystucki jeremystucki requested a review from Mad-Kat March 25, 2025 15:23
@jeremystucki jeremystucki self-assigned this Mar 25, 2025
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 0ecdf3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
yak-swc Patch
next-yak Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeremystucki jeremystucki requested a review from jantimon March 26, 2025 12:50
@jeremystucki jeremystucki force-pushed the minor-file-visitor-refactoring branch from e2c8796 to 0ecdf3b Compare March 26, 2025 12:55
@jeremystucki
Copy link
Member Author

FYI I force-pushed to use my DG email address.

Copy link
Contributor

@Mad-Kat Mad-Kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Mad-Kat Mad-Kat merged commit b3e4fec into main Mar 26, 2025
6 checks passed
@Mad-Kat Mad-Kat deleted the minor-file-visitor-refactoring branch March 26, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants