Allow atoms function in css prop #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d96fa36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mad-Kat
force-pushed
the
feature/atoms-in-css-prop
branch
from
1f353d6 to
d96fa36
Compare
There was a problem hiding this comment.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- packages/docs/content/docs/features.mdx: Language not supported
- packages/example/app/global.css: Language not supported
- packages/yak-swc/yak_swc/tests/fixture/css-prop-invalid/output.dev.stderr: Language not supported
- packages/yak-swc/yak_swc/tests/fixture/css-prop-invalid/output.prod.stderr: Language not supported
| if let Callee::Expr(callee) = &call_expr.callee { | ||
| if let Expr::Ident(ident) = &**callee { | ||
| // If it looks like an atoms function call based on the name, handle it differently | ||
| if ident.sym.as_ref() == "atoms" { |
There was a problem hiding this comment.
Hard-coding the string 'atoms' for function identification may fail if the atoms function is imported using an alias; consider using yak_imports.get_yak_library_name_for_ident(&ident.to_id()) to make the check more robust.
Suggested change
| if ident.sym.as_ref() == "atoms" { | |
| if yak_imports.get_yak_library_name_for_ident(&ident.to_id()) == "atoms" { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #290
Completing this PR will add the possibility to use
atomsdirectly in the css prop. E.g.