Skip to content

Bug/555 scale filter menu #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Bug/555 scale filter menu #570

merged 6 commits into from
Sep 14, 2021

Conversation

elislaats
Copy link
Contributor

@elislaats elislaats commented Sep 13, 2021

Description

Small fix of an issue where the filter-menu became partially hidden on screens with a small height.

Added fix for changing cards on open modal

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Go to the project overview page
  2. Make your window-height smaller. Either by dragging it or trough inspecting the element as described in the linked issue
  3. See the scrollbar appear on the filtermenu and check that you can use all the filters

Link to issue

Closes: #555
Closes: #571

Copy link
Contributor

@BartvanEijkelenburg BartvanEijkelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DaveBouman
Copy link
Contributor

Everything works as expected!

@elislaats elislaats merged commit c34d428 into develop Sep 14, 2021
@elislaats elislaats deleted the bug/555-scale-filter-menu branch September 14, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project overview card changes size on click Filter menu doesn't scale as expected on smaller screens
3 participants