Skip to content

Content homepage refactor #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2021
Merged

Content homepage refactor #530

merged 7 commits into from
Jun 24, 2021

Conversation

niraymak
Copy link
Member

@niraymak niraymak commented Jun 22, 2021

Description

We received content for our homepage from Fontys' MarCom department.
In this PR the content was processed into our homepage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Start frontend
  2. See most of the content on the homepage

Link to issue

Closes: #502

@RubenFricke RubenFricke marked this pull request as draft June 22, 2021 07:52
@waltersajtos
Copy link
Member

Is this ready for review?

@RubenFricke RubenFricke marked this pull request as ready for review June 23, 2021 11:17
@RubenFricke RubenFricke self-assigned this Jun 23, 2021
Copy link
Member

@waltersajtos waltersajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waltersajtos waltersajtos merged commit 52dd14e into develop Jun 24, 2021
@waltersajtos waltersajtos deleted the feature/502-marcom-content branch June 24, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEEDS MORE INFORMATION] Fill in content from MarCom in homepage
4 participants