-
Notifications
You must be signed in to change notification settings - Fork 6
Small bugfixes #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small bugfixes #418
Conversation
Fixed up some small bugfixes: - Alerts go away automatically - Edit contributors don't overflow - Project overview names don't overflow - Opening project detail modal doesn't screw up the layout
…gitalExcellence/dex-frontend into origin/bugfix/refactor-friday
Thanks for the fixes @yuqera, I tested all of them and they work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Good work! Please send me a message on slack when you fixed the conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Fixed up some small bugfixes:
Description
A few sentences describing the overall goals of the pull request's commits.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
1.1 Edit a project
1.2 See the alert on the top of the screen
1.3 Wait 5 seconds till the alert goes away
2.1 Edit a project
2.2 Add a contributor with a long name
2.3 See that the contributor gets hidden with 3 dots
3.1 Go to project overview
3.2 See that long usernames get hidden with 3 dots
4.1 Open a project inside project overview
4.2 Close it
4.3 See that everything is still aligned with each other
Link to issue
#408, #400, #401, #392, #354
Closes: #408 #400 #401 #392 #354