Skip to content

Small bugfixes #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6 commits merged into from
Jan 28, 2021
Merged

Small bugfixes #418

6 commits merged into from
Jan 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2021

Fixed up some small bugfixes:

  • Alerts go away automatically
  • Edit contributors don't overflow
  • Project overview usernames don't overflow
  • Opening project detail modal doesn't screw up the layout
  • When entering something in the search bar and clicking projects in the navbar, the page reloads.

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

1.1 Edit a project
1.2 See the alert on the top of the screen
1.3 Wait 5 seconds till the alert goes away

2.1 Edit a project
2.2 Add a contributor with a long name
2.3 See that the contributor gets hidden with 3 dots

3.1 Go to project overview
3.2 See that long usernames get hidden with 3 dots

4.1 Open a project inside project overview
4.2 Close it
4.3 See that everything is still aligned with each other

Link to issue

#408, #400, #401, #392, #354

Closes: #408 #400 #401 #392 #354

Fixed up some small bugfixes:
 - Alerts go away automatically
 - Edit contributors don't overflow
 - Project overview names don't overflow
 - Opening project detail modal doesn't screw up the layout
@ghost ghost requested review from Brend-Smits and rubenb994 January 26, 2021 14:24
@Brend-Smits
Copy link
Member

Thanks for the fixes @yuqera, I tested all of them and they work fine.
Can you please fix the conflicts? If we can get another review in, we can merge this and get it in with this release

waltersajtos
waltersajtos previously approved these changes Jan 28, 2021
Copy link
Member

@waltersajtos waltersajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Good work! Please send me a message on slack when you fixed the conflicts

elislaats
elislaats previously approved these changes Jan 28, 2021
Copy link
Contributor

@elislaats elislaats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@ghost ghost dismissed stale reviews from elislaats and waltersajtos via 82e5b4a January 28, 2021 14:30
Copy link
Member

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ghost ghost merged commit 1f6198f into develop Jan 28, 2021
@ghost ghost deleted the origin/bugfix/refactor-friday branch January 28, 2021 14:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants