-
Notifications
You must be signed in to change notification settings - Fork 6
101 fix broken styling ngx #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken styling left over from Clarity. Fixed forgotten styling on multiple pages.
updated changelog
MaxKorlaar
reviewed
May 4, 2020
src/app/modules/highlight/top-highlight-cards/top-highlight-cards.component.html
Show resolved
Hide resolved
src/app/modules/highlight/top-highlight-cards/top-highlight-cards.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/highlight/top-highlight-cards/top-highlight-cards.component.scss
Outdated
Show resolved
Hide resolved
14 tasks
Co-authored-by: Max Korlaar <[email protected]>
Co-authored-by: Max Korlaar <[email protected]>
…rds.component.scss Co-authored-by: Max Korlaar <[email protected]>
Co-authored-by: Max Korlaar <[email protected]>
Co-authored-by: Max Korlaar <[email protected]>
Co-authored-by: Max Korlaar <[email protected]>
…rds.component.scss Co-authored-by: Max Korlaar <[email protected]>
Use Bootstrap SCSS instead of CSS
Brend-Smits
approved these changes
May 5, 2020
MaxKorlaar
reviewed
May 5, 2020
Co-authored-by: Max Korlaar <[email protected]>
…)use variables and functions from Bootstrap
MaxKorlaar
approved these changes
May 5, 2020
MaxKorlaar
suggested changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app-layout.component.scss needs some rework for the btn-primary
class.
MaxKorlaar
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced Clarity with ngx bootstrap.
Fixed styling that got broken after replacing Clarity and fixed other styling problems.
Accordion styling that currently is implemented in the global scss will be fixed in a later issue.
Type of change
Checklist
Link to issue
Closes: #101 #94