Skip to content

101 fix broken styling ngx #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 5, 2020
Merged

101 fix broken styling ngx #107

merged 15 commits into from
May 5, 2020

Conversation

RensNooren
Copy link
Contributor

@RensNooren RensNooren commented May 4, 2020

Description

Replaced Clarity with ngx bootstrap.
Fixed styling that got broken after replacing Clarity and fixed other styling problems.
Accordion styling that currently is implemented in the global scss will be fixed in a later issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Link to issue

Closes: #101 #94

Brend-Smits and others added 2 commits April 20, 2020 16:56
Fixed broken styling left over from Clarity. Fixed forgotten styling on multiple pages.
updated changelog
@Brend-Smits Brend-Smits mentioned this pull request May 4, 2020
14 tasks
@Brend-Smits Brend-Smits requested a review from MaxKorlaar May 5, 2020 08:36
Copy link
Member

@MaxKorlaar MaxKorlaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app-layout.component.scss needs some rework for the btn-primary class.

@MaxKorlaar MaxKorlaar merged commit 5337051 into develop May 5, 2020
@rubenb994 rubenb994 deleted the 101-fix-broken-styling-ngx branch June 15, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: broken styling after clarity removal
3 participants