Skip to content

When image is not found, show placeholder instead of 404 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Brend-Smits opened this issue Nov 6, 2020 · 0 comments · Fixed by #359
Closed

When image is not found, show placeholder instead of 404 #339

Brend-Smits opened this issue Nov 6, 2020 · 0 comments · Fixed by #359
Assignees
@Brend-Smits
Labels
enhancement New feature or request Good first issue Good first issue to get to know the project internally.

Comments

@Brend-Smits
Copy link
Member

Is your feature request related to a problem? Please describe.
When an image returns a 404 code, indicating that it's not found. It shows ugly text with image not found icon.

Describe the solution you'd like
We should return a placeholder instead of:
image

Additional context
Add any other context or screenshots about the feature request here.
@Brend-Smits Brend-Smits added enhancement New feature or request Good first issue Good first issue to get to know the project internally. labels Nov 6, 2020
@Brend-Smits Brend-Smits self-assigned this Nov 19, 2020
Brend-Smits added a commit that referenced this issue Nov 19, 2020
@Brend-Smits
Fixes #339 - Show placeholder image when image path errors
73d24a8
@Brend-Smits Brend-Smits mentioned this issue Nov 19, 2020
Merged
11 tasks
@Brend-Smits Brend-Smits mentioned this issue Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brend-Smits Brend-Smits

Labels
enhancement New feature or request Good first issue Good first issue to get to know the project internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #339 - Show placeholder image when image path errors DigitalExcellence/dex-frontend
1 participant
@Brend-Smits