Skip to content

Bugfix/454 remove files #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Bugfix/454 remove files #464

merged 8 commits into from
Jun 22, 2021

Conversation

RubenFricke
Copy link
Member

Description

Able to remove images from project

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Create a project with a project icon and project image(s)
  2. Update this project and remove the images
  3. Validate that the images get removed

Link to issue

Closes: #454

@RubenFricke RubenFricke self-assigned this Jun 19, 2021
@RubenFricke RubenFricke requested a review from Arilith June 21, 2021 07:34
Copy link
Contributor

@Arilith Arilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me! Good job.

I have one minor detail, which maybe should be changed for consistency:
When trying to "delete" an image that does not exist while updating a project, the following error is produced:

The specified image was not found while creating project.
(FC816E40-31A6-4187-BEBA-D22F06019F8F)

However, it's updating the project, not creating. Maybe something to keep in mind for consistency.

@RubenFricke RubenFricke requested a review from Arilith June 21, 2021 12:33
Copy link
Contributor

@Arilith Arilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Looks great.

@RubenFricke RubenFricke merged commit ba70b68 into develop Jun 22, 2021
@RubenFricke RubenFricke deleted the bugfix/454-remove-files branch June 22, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove images / project icon from a project
4 participants