Skip to content

Make "bundlesize" a dev dependency #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

twinkelmann
Copy link
Contributor

"bundlesize" has an the following dependencies: "brotli-size" > "iltorb".

"iltorb" crashes often when trying to compile, but that's not the problem.
The problem is that "bundlesize" should be a dev dependency and not a normal one. That means it shouldn't even be downloaded by 90% of users.

"bundlesize" has an the following dependencies: "brotli-size" > "iltorb".

"iltorb" crashes often when trying to compile, but that's not the problem.
The problem is that "bundlesize" should be a dev dependency and not a normal one. That means it shouldn't even be downloaded by 90% of users.
@garethhunt
Copy link

@hisk It would be great if you could merge this.

@twinkelmann
Copy link
Contributor Author

This is causing #53

@cookieshell cookieshell changed the base branch from master to patch-3.0.0 June 17, 2019 08:44
@cookieshell cookieshell merged commit 2e3284f into DesignRevision:patch-3.0.0 Jun 17, 2019
@cookieshell
Copy link
Member

@winktim Awesome! Thanks for your contribution and sorry for the delay. We'll include this in the 3.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants