Skip to content

[pg] Remove non-existent min option #72455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

vladshcherbin
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: source code
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

There is no min option and a pending issue to add it.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 10, 2025

@vladshcherbin Thank you for submitting this PR!

This is a live comment that I will keep updated.

2 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72455,
  "author": "vladshcherbin",
  "headCommitOid": "bb9659cea9f4192be122a807cd3cce0b183e0873",
  "mergeBaseOid": "9b4624e2c953b1328a72d58da87f255dcccbaad1",
  "lastPushDate": "2025-04-10T18:40:32.000Z",
  "lastActivityDate": "2025-04-11T22:07:01.000Z",
  "mergeOfferDate": "2025-04-11T21:56:53.000Z",
  "mergeRequestDate": "2025-04-11T22:07:01.000Z",
  "mergeRequestUser": "vladshcherbin",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "pg-pool",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg-pool/pg-pool-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "aleung",
        "mainnika"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2025-04-11T21:56:14.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2794815206,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 10, 2025

🔔 @aleung @mainnika @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 10, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Apr 10, 2025
@typescript-bot
Copy link
Contributor

@vladshcherbin The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits multiple packages and removed The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Apr 10, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Apr 10, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 10, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 11, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Apr 11, 2025
@vladshcherbin
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Apr 11, 2025
@typescript-bot typescript-bot merged commit 91daab5 into DefinitelyTyped:master Apr 11, 2025
4 checks passed
@vladshcherbin vladshcherbin deleted the patch-1 branch April 11, 2025 22:08
@htrajan
Copy link

htrajan commented Apr 25, 2025

Just a heads up -- I recently made the contribution to pg-pool to finally support the min parameter. The update should be coming through in a minor release on Monday.

htrajan added a commit to htrajan/DefinitelyTyped that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
Status: Recently Merged
Development

Successfully merging this pull request may close these issues.

4 participants