-
Notifications
You must be signed in to change notification settings - Fork 30.4k
[pg] Remove non-existent min option #72455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vladshcherbin Thank you for submitting this PR! This is a live comment that I will keep updated. 2 packages in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72455,
"author": "vladshcherbin",
"headCommitOid": "bb9659cea9f4192be122a807cd3cce0b183e0873",
"mergeBaseOid": "9b4624e2c953b1328a72d58da87f255dcccbaad1",
"lastPushDate": "2025-04-10T18:40:32.000Z",
"lastActivityDate": "2025-04-11T22:07:01.000Z",
"mergeOfferDate": "2025-04-11T21:56:53.000Z",
"mergeRequestDate": "2025-04-11T22:07:01.000Z",
"mergeRequestUser": "vladshcherbin",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "pg-pool",
"kind": "edit",
"files": [
{
"path": "types/pg-pool/pg-pool-tests.ts",
"kind": "test"
}
],
"owners": [
"aleung",
"mainnika"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "pg",
"kind": "edit",
"files": [
{
"path": "types/pg/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pspeter3",
"HoldYourWaffle"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2025-04-11T21:56:14.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2794815206,
"ciResult": "pass"
} |
🔔 @aleung @mainnika @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select |
@vladshcherbin The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Ready to merge |
Just a heads up -- I recently made the contribution to pg-pool to finally support the min parameter. The update should be coming through in a minor release on Monday. |
… option by @vladshcherbin" This reverts commit 91daab5.
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
package.json
.There is no min option and a pending issue to add it.