dns fixup in build args #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
requested changes
Oct 23, 2024
lionello
reviewed
Oct 24, 2024
lionello
requested changes
Oct 24, 2024
| return val | ||
| } | ||
|
|
||
| func (s *ServiceNameReplacer) hasServiceName(name string) bool { |
There was a problem hiding this comment.
little weird to have a exported struct but then using a private method.
| } | ||
| } | ||
|
|
||
| func (s *ServiceNameReplacer) replaceServiceNameWithDNS(serviceName string, key, value string, replacementMode ReplacementMode) string { |
lionello
requested changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #394
Extract out service name replacement into it's own struct and function
Use same service name replacement for build arguments