Skip to content

remove extraneous workingDir from Loader struct. #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nullfunc
Copy link
Contributor

@nullfunc nullfunc commented Oct 21, 2024

workingDir was removed in #756 as it was interfering with current working directory flag. Cleaning up missed code.

@nullfunc nullfunc requested review from jordanstephens and lionello and removed request for jordanstephens October 21, 2024 22:31
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated your PR description to link to the previous PR

@nullfunc
Copy link
Contributor Author

I updated your PR description to link to the previous PR

Thanks!

@lionello lionello merged commit 5ed26fb into main Oct 22, 2024
11 checks passed
@lionello lionello deleted the eric-remove-further-workdir-reference branch October 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants