Skip to content

Fixes for NPM #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fixes for NPM #726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f19b4
Fixes for NPM
lionello Oct 7, 2024
8d20c41
move chmod to package.json
lionello Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,18 +318,18 @@ jobs:
runs-on: ubuntu-latest
needs: go-release
steps:
- name: Update Windows s.defang.io/defang_win_amd64.zip short link
run: |
curl --request POST \
--url https://api.short.io/links/$DEFANG_WIN_AMD64_LNK \
--header "Authorization: $SHORTIO_PK" \
--header 'accept: application/json' \
--header 'content-type: application/json' \
--data "{\"originalURL\":\"https://github.com/DefangLabs/defang/releases/download/${TAG}/defang_${TAG#v}_windows_amd64.zip\"}"
env:
SHORTIO_PK: ${{ secrets.SHORTIO_PK }}
TAG: ${{ github.ref_name }}
DEFANG_WIN_AMD64_LNK: "lnk_4vSQ_CDukZ5POEE4o0mMDysr2U"
# - name: Update Windows s.defang.io/defang_win_amd64.zip short link
# run: |
# curl --request POST \
# --url https://api.short.io/links/$DEFANG_WIN_AMD64_LNK \
# --header "Authorization: $SHORTIO_PK" \
# --header 'accept: application/json' \
# --header 'content-type: application/json' \
# --data "{\"originalURL\":\"https://github.com/DefangLabs/defang/releases/download/${TAG}/defang_${TAG#v}_windows_amd64.zip\"}"
# env:
# SHORTIO_PK: ${{ secrets.SHORTIO_PK }}
# TAG: ${{ github.ref_name }}
# DEFANG_WIN_AMD64_LNK: "lnk_4vSQ_CDukZ5POEE4o0mMDysr2U"

- name: Trigger CLI Autodoc
uses: peter-evans/repository-dispatch@v3
Expand All @@ -356,7 +356,7 @@ jobs:
node-version: "20" # same as the version in flake.nix
registry-url: https://registry.npmjs.org

- name: Publish to NPM
- name: Build npm package
shell: bash
working-directory: ./pkgs/npm
run: |
Expand All @@ -376,7 +376,8 @@ jobs:
# make the cli.js executable
chmod u+x ./bin/cli.js

# publish the package
npm publish --access public
- run: npm publish --access public
shell: bash
working-directory: ./pkgs/npm
env:
NODE_AUTH_TOKEN: ${{ secrets.NPMJS_AUTH_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new environment secret for the release env

Loading
Loading