update gRPC PutConfig/PutSecret message #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make enums for configs update with latest protos update for change to sensitivity to enum update compiled grpc
nullfunc
force-pushed
the
eric-update-putconfig-protos
branch
from
bcecf30 to
63d199d
Compare
lionello
reviewed
Sep 11, 2024
src/protos/io/defang/v1/fabric.proto
Outdated
| message GetConfigsRequest { | ||
| repeated ConfigKey configs = 1; | ||
| optional ConfigOptions options = 2; |
There was a problem hiding this comment.
Suggested change
| optional ConfigOptions options = 2; | |
| ConfigOptions options = 2; |
src/protos/io/defang/v1/fabric.proto
Outdated
| string name = 1; | ||
| string value = 2; | ||
| string project = 3; // defaults to tenant ID | ||
| } | ||
|
|
||
| enum Sensitivity { | ||
| NON_SENSITIVE = 0; |
There was a problem hiding this comment.
UNSPECIFIED_… or …_UNSPECIFIED
src/protos/io/defang/v1/fabric.proto
Outdated
| } | ||
|
|
||
| enum ConfigType { | ||
| RAW = 0; |
src/protos/io/defang/v1/fabric.proto
Outdated
| } | ||
|
|
||
| message ConfigKey { | ||
| string name = 1; | ||
| string project = 2; // defaults to tenant ID | ||
| } | ||
|
|
||
| enum ConfigOptions { | ||
| NO_OPTION = 0; |
src/protos/io/defang/v1/fabric.proto
Outdated
| message GetConfigsRequest { | ||
| repeated ConfigKey configs = 1; | ||
| optional ConfigOptions options = 2; |
There was a problem hiding this comment.
Suggested change
| optional ConfigOptions options = 2; | |
| ConfigOptions options = 2; |
lionello
requested changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to PutConfig/PutSecret to use the same message, to allow backend to handle Put using same handling code.