Implement Subscribe API call for BYOC #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwardrf
commented
Aug 8, 2024
•
edwardrf
commented
- Implement subscribe API call for byoc aws client, using ecsEventsHandler interface to share data from log tailing to the Subscribe api call
- Make collection stream compliant with the server stream interface, keep all channel logic inside collection stream
- Update term package and tail command to output the same log entry in a single log call, so messages will not be interleaved
also fix collection stream error handling
Keep all channel logic inside collection stream code
nullfunc
reviewed
Aug 13, 2024
nullfunc
reviewed
Aug 13, 2024
nullfunc
reviewed
Aug 13, 2024
nullfunc
reviewed
Aug 13, 2024
lionello
reviewed
Aug 13, 2024
lionello
reviewed
Aug 13, 2024
nullfunc
reviewed
Aug 16, 2024
edwardrf
force-pushed
the
edw-byoc-subscribe
branch
from
1ad7836 to
fff08ef
Compare
lionello
reviewed
Aug 19, 2024
| @@ -158,7 +184,8 @@ func (t *Term) Printlnc(c Color, v ...any) (int, error) { | |||
| } | |||
|
|
|||
| func (t *Term) Printfc(c Color, format string, v ...any) (int, error) { | |||
| return outputf(t.stdout, c, format, v...) | |||
| line := ensureNewline(fmt.Sprintf(format, v...)) | |||
There was a problem hiding this comment.
Removed the less usefull outputf func above
lionello
approved these changes
Aug 22, 2024
Co-authored-by: Lio李歐 <[email protected]>
This reverts commit ba38ee9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.