-
Notifications
You must be signed in to change notification settings - Fork 12
Allow CMD other than curl and wget #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
356d631
to
9fdcb8e
Compare
0f4dfd6
to
53cfc52
Compare
53cfc52
to
8b14708
Compare
Do we have a place in the docs to capture things like this where defang requires something more narrow than docker requires in the compose file? |
No. Just in our tests. See |
Fixes
flask
sample which uses python for healthcheck.We now allow any healthcheck, as long as we can find an "localhost" host URL somewhere in the cmd. Also relaxing the
NONE
healthcheck to allow for args, since we'd ignore them anyway.defang_service