Skip to content

Allow CMD other than curl and wget #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Allow CMD other than curl and wget #532

merged 4 commits into from
Aug 2, 2024

Conversation

lionello
Copy link
Member

@lionello lionello commented Jul 8, 2024

Fixes flask sample which uses python for healthcheck.

We now allow any healthcheck, as long as we can find an "localhost" host URL somewhere in the cmd. Also relaxing the NONE healthcheck to allow for args, since we'd ignore them anyway.

  • post-merge: uptake latest defang mod in backend
  • update healthcheck parsing in defang_service

@lionello lionello force-pushed the lio-healthcheck-urls branch from 356d631 to 9fdcb8e Compare July 8, 2024 23:10
@lionello lionello added this to the July2024 milestone Jul 8, 2024
@lionello lionello force-pushed the lio-healthcheck-urls branch 2 times, most recently from 0f4dfd6 to 53cfc52 Compare July 18, 2024 13:26
@lionello lionello modified the milestones: July2024, Aug2024 Aug 1, 2024
@lionello lionello force-pushed the lio-healthcheck-urls branch from 53cfc52 to 8b14708 Compare August 2, 2024 17:24
@lionello lionello marked this pull request as ready for review August 2, 2024 17:24
@jordanstephens
Copy link
Member

Do we have a place in the docs to capture things like this where defang requires something more narrow than docker requires in the compose file?

@lionello lionello requested a review from jordanstephens August 2, 2024 18:04
@lionello
Copy link
Member Author

lionello commented Aug 2, 2024

Do we have a place in the docs to capture things like this where defang requires something more narrow than docker requires in the compose file?

No. Just in our tests. See tests folder. Would be great to document, but that's going to be out of date real fast. Generate docs from tests? 🤔

@lionello lionello merged commit 5548bf6 into main Aug 2, 2024
7 checks passed
@lionello lionello deleted the lio-healthcheck-urls branch August 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants