move notarization into goreleaser #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lionello
commented
Jul 5, 2024
•
lionello
commented
- fix for Windows: released zip has unsigned exe because we signed after archiving
- fix for MacOS: move notarization into GoReleaser so we don't announce a new version until after notarization succeeded
lionello
force-pushed
the
lio-notarization-goreleaser
branch
from
80f55a9 to
350edcc
Compare
lionello
force-pushed
the
lio-notarization-goreleaser
branch
from
544ea28 to
71b9645
Compare
lionello
force-pushed
the
lio-notarization-goreleaser
branch
from
71b9645 to
58a7a86
Compare
lionello
force-pushed
the
lio-notarization-goreleaser
branch
from
58a7a86 to
7b02cdd
Compare
lionello
force-pushed
the
lio-notarization-goreleaser
branch
from
7b02cdd to
bef2ec9
Compare
edwardrf
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.