Skip to content

fix regressions in generate #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix regressions in generate #525

merged 2 commits into from
Jul 5, 2024

Conversation

lionello
Copy link
Member

@lionello lionello commented Jul 5, 2024 •
edited
Loading

  • editor opened the wrong folder
  • hint shows multiple configs on one command (which fails)

@lionello lionello requested review from edwardrf and nullfunc July 5, 2024 00:31
edwardrf
edwardrf approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@edwardrf edwardrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionello lionello merged commit 3b44b83 into main Jul 5, 2024
7 checks passed
@lionello lionello deleted the lio-fix-generate branch July 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardrf edwardrf edwardrf approved these changes

@nullfunc nullfunc Awaiting requested review from nullfunc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionello @edwardrf