Keep compose as-is #523
Merged
Keep compose as-is #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
commented
Jul 3, 2024
lionello
commented
Jul 3, 2024
lionello
force-pushed
the
lio-compose-file
branch
from
3cb6990 to
42b15df
Compare
Closed
lionello
force-pushed
the
lio-compose-file
branch
from
5133fe4 to
49213fd
Compare
lionello
force-pushed
the
lio-compose-file
branch
from
8ca0ddd to
77ee8cb
Compare
Closed
jordanstephens
approved these changes
Sep 3, 2024
lionello
force-pushed
the
lio-compose-file
branch
from
e55824f to
04f3cbb
Compare
lionello
force-pushed
the
lio-compose-file
branch
2 times, most recently
from
cff45b6 to
0deff7c
Compare
lionello
commented
Oct 11, 2024
lionello
commented
Oct 15, 2024
1 task
lionello
force-pushed
the
lio-compose-file
branch
3 times, most recently
from
06f8648 to
5aa7350
Compare
lionello
force-pushed
the
lio-compose-file
branch
from
5aa7350 to
4e275c2
Compare
separate fixup from conversion deprecate old compose proto messages revert buf.gen.yaml remove obsolete functions add healthcheck times to test add type aliases Fix getUnreferencedManagedResources tests Keep the yaml Update cli.nix vendorHash remarks Update src/pkg/cli/client/byoc/do/byoc.go Update src/protos/io/defang/v1/fabric.proto For now, use Ports in ServiceInfo
lionello
force-pushed
the
lio-compose-file
branch
from
4e275c2 to
7216125
Compare
edwardrf
approved these changes
Oct 25, 2024
nullfunc
pushed a commit
that referenced
this pull request
Oct 25, 2024
* wip: keep compose as-is separate fixup from conversion deprecate old compose proto messages revert buf.gen.yaml remove obsolete functions add healthcheck times to test add type aliases Fix getUnreferencedManagedResources tests Keep the yaml Update cli.nix vendorHash remarks Update src/pkg/cli/client/byoc/do/byoc.go Update src/protos/io/defang/v1/fabric.proto For now, use Ports in ServiceInfo * fix unit test * update cli.nix * move compose constants to compose package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI changes for removing the Compose-like proto buffer messages and replace them by sending a normalized compose blob.
This uses the Google well-knownStructtype, which can encapsulate any struct-like data structure (includingmap[string]any). This has the nice side-effect of becoming a regular JSON object when unmarshaled in JS/TS, so we can access the fields regularly without the currentprotomsg.getXyz()calls.Ready for review, but still requires the backend/mvp changes.