Issue 140 #516
Merged
Issue 140 #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
requested changes
Jun 28, 2024
lionello
requested changes
Jun 29, 2024
lionello
requested changes
Jul 3, 2024
lionello
reviewed
Jul 4, 2024
lionello
reviewed
Jul 4, 2024
…t and collectUnsetEnvVars function
lionello
reviewed
Jul 4, 2024
src/cmd/cli/command/commands.go
Outdated
| loader := compose.Loader{ComposeFilePath: filepath.Join(prompt.Folder, "compose.yaml")} | ||
| project, _ := loader.LoadCompose(cmd.Context()) | ||
|
|
||
| envVars := collectUnsetEnvVars(project) // ir err != nil -> proj == nil, which is handled in the collectUnsetEnvVars function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to closes #140 where the hints generated by the current defang generate command is insufficient. I accomplish this by unmarshalling the compose.yaml file to collect the environment variables that need to be set with defang config set.