defang upgrade command #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaeltm
reviewed
Jun 5, 2024
jordanstephens
approved these changes
Aug 13, 2024
we decided we didn't feel comfortable with proactively trying to run other processes to update. we may revisit this in the future, but for now this is a practical compromise.
src/pkg/cli/update.go
Outdated
| } | ||
|
|
||
| func homebrewPrefix(ctx context.Context) string { | ||
| output, err := exec.CommandContext(ctx, "brew", "config").Output() |
There was a problem hiding this comment.
@edwardrf how do we feel about this?
lionello
commented
Aug 16, 2024
lionello
commented
Aug 16, 2024
|
|
||
| // Check if we're running in PowerShell | ||
| if _, exists := os.LookupEnv("PSModulePath"); exists { | ||
| printInstructions(`pwsh -c "iwr https://s.defang.io/defang_win_amd64.zip -OutFile defang.zip"`) |
There was a problem hiding this comment.
We have since added winget support!
winget install defang
defang generate
There was a problem hiding this comment.
@lionello does this change look right, then?
Suggested change
| printInstructions(`pwsh -c "iwr https://s.defang.io/defang_win_amd64.zip -OutFile defang.zip"`) | |
| printInstructions(`winget install defang`) |
There was a problem hiding this comment.
I think that's good enough, but we might have to add logic to check whether it was installed with winget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit hacky, but I think this would work well!! Fixes #41 and #238
This PR makes it easier to update the
defangCLI by introducing adefang upgradecommand. This is somewhat challenging because thedefangCLI may be installed through many different mechanisms. We host our own direct installation scripts athttps://s.defang.io/installandhttps://s.defang.io/defang_win_amd64.zip, but we also publish the CLI to homebrew, and nix. Thedefang upgradecommand will try to determine which mechanism was used, and then prints appropriate instructions on how to upgrade. We originally considered running the update ourselves, but decided that we didn't feel comfortable shelling out to tools which are sort of out of our domain.