Skip to content

update proto to include deployment type #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/cmd/cli/command/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -970,11 +970,22 @@ var deleteCmd = &cobra.Command{
},
}

// deploymentsCmd and deploymentsListCmd do the same thing. deploymentsListCmd is for backward compatibility.
var deploymentsCmd = &cobra.Command{
Use: "deployments",
Short: "Manage Deployments",
Aliases: []string{"deployment", "deploys", "deps", "dep"},
Annotations: authNeededAnnotation,
Args: cobra.NoArgs,
Short: "List deployments",
RunE: func(cmd *cobra.Command, args []string) error {
loader := configureLoader(cmd)
projectName, err := loader.LoadProjectName(cmd.Context())
if err != nil {
return err
}

return cli.DeploymentsList(cmd.Context(), projectName, client)
},
}

var deploymentsListCmd = &cobra.Command{
Expand All @@ -983,6 +994,7 @@ var deploymentsListCmd = &cobra.Command{
Annotations: authNeededAnnotation,
Args: cobra.NoArgs,
Short: "List deployments",
Deprecated: "use 'deployments' instead",
RunE: func(cmd *cobra.Command, args []string) error {
loader := configureLoader(cmd)
projectName, err := loader.LoadProjectName(cmd.Context())
Expand Down
1 change: 1 addition & 0 deletions src/pkg/cli/deploymentsList.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type PrintDeployment struct {

func DeploymentsList(ctx context.Context, projectName string, client client.GrpcClient) error {
response, err := client.ListDeployments(ctx, &defangv1.ListDeploymentsRequest{
Type: defangv1.DeploymentType_DEPLOYMENT_TYPE_HISTORY,
Project: projectName,
})
if err != nil {
Expand Down
Loading
Loading