Skip to content

handle x-defang-llm fixup only openai-access-gateway image #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025

Conversation

nullfunc
Copy link
Contributor

@nullfunc nullfunc commented May 5, 2025

Description

For openai-access-gateway we want to set a default port configuration if one is not defined.
Also allow in playground.

Linked Issues

None - this is a continuation of PR #1138

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

@nullfunc nullfunc requested a review from jordanstephens May 5, 2025 19:42
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "image root" is not a known concept, but "image repo" is, so let's use that.

@nullfunc nullfunc requested a review from lionello May 6, 2025 18:54
@lionello lionello merged commit 28de7f6 into main May 6, 2025
15 checks passed
@lionello lionello deleted the eric-x-defang-llm-fixup-update branch May 6, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants