Skip to content

Remove support for Goreleaser to publish a nix derivation #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

KevyVo
Copy link
Contributor

@KevyVo KevyVo commented Mar 25, 2025

Description

After exploring many options and a lot of discussion we have decided to just remove the support for GoReleaserbot can generate and publish a nix derivation.
The cons outweight the pros to keep the Nix support for goreleaser.

For more context please read the attached issue below.

Linked Issues

#24

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

After exploring many options and a lot of discussion we
have decided to just remove the support for GoReleaserbot
can generate and publish a nix derivation.
The cons outweight the pros to keep the Nix support for goreleaser.
@KevyVo KevyVo requested a review from lionello March 25, 2025 18:55
@KevyVo KevyVo self-assigned this Mar 25, 2025
@KevyVo KevyVo linked an issue Mar 25, 2025 that may be closed by this pull request
@lionello lionello merged commit cc409e7 into main Mar 27, 2025
12 checks passed
@lionello lionello deleted the kevin/goreleaserbot branch March 27, 2025 20:33
lionello added a commit that referenced this pull request Mar 28, 2025
Goreleaser nix rule was commented in #1078
@lionello lionello mentioned this pull request Mar 28, 2025
3 tasks
lionello added a commit that referenced this pull request Mar 29, 2025
Goreleaser nix rule was commented in #1078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable branch protection for main branch
2 participants